Fix docstrings for int/u64, int/s64 and int/to-number#1544
Merged
bakpakin merged 2 commits intojanet-lang:masterfrom Jan 14, 2025
Merged
Fix docstrings for int/u64, int/s64 and int/to-number#1544bakpakin merged 2 commits intojanet-lang:masterfrom
bakpakin merged 2 commits intojanet-lang:masterfrom
Conversation
Update the cfun_to_number docstring to indicate that it handles values up to JANET_INTMAX_INT64 (75845c0), rather than up to int32, what the current docstring says.
Update the docstrings of the u64 and s64 functions to indicate that they work on numbers as well strings. Previously the docstring only mentioned string support.
Contributor
|
As an additional data point, it looks like: (int/to-number (+ (int/u64 (math/pow 2 53)) 1))leads to an error currently: FWIW, one less seems to work: (int/to-number (int/u64 (math/pow 2 53)))
# =>
9007199254740992 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All credits go to @sogaiu (see this Zulip chat).
The current doc strings for
int/u64andint/s64say that these functions only support strings. But as far as I can tell from the diff they always support both numbers and strings, and the test suites cover those cases. I therefore updated the docstrings to indicate that.int/to-numberused to only supportsint32values but this commit added support for up toJANET_INTMAX_INT64.This isn't the most ground breaking commit but I was certainly a bit confused about what I can do with these functions when I was dealing with
bxoring 64bit integers for Advent of Code.