Skip to content

fix: dune bootstrap#53

Closed
rgrinberg wants to merge 1 commit intomasterfrom
ps/rr/fix__dune_bootstrap
Closed

fix: dune bootstrap#53
rgrinberg wants to merge 1 commit intomasterfrom
ps/rr/fix__dune_bootstrap

Conversation

@rgrinberg
Copy link
Copy Markdown
Collaborator

For some reason, dune's bootstrap process doesn't like
enabling CAML_INTERNALS. See the error in CI:

cd _boot && /Users/runner/work/dune/dune/_opam/bin/ocamlopt.opt -c -g -I +unix -I +threads spawn_stubs.c
vendor/spawn/src/spawn_stubs.c:481:20: error: implicit declaration of function 'caml_convert_signal_number' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
      int signal = caml_convert_signal_number(Long_val(Field(v_signals_list, 0)));
                   ^
1 error generated.

I'm not sure why, but it's easy enough to workaround it be declaring the
function that we need.

It's also a little cleaner this way as we only make the one private
function we need available rather than everything.

Signed-off-by: Rudi Grinberg me@rgrinberg.com

For some reason, dune's bootstrap process doesn't like
enabling CAML_INTERNALS. See the error in CI:

```
cd _boot && /Users/runner/work/dune/dune/_opam/bin/ocamlopt.opt -c -g -I +unix -I +threads spawn_stubs.c
vendor/spawn/src/spawn_stubs.c:481:20: error: implicit declaration of function 'caml_convert_signal_number' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
      int signal = caml_convert_signal_number(Long_val(Field(v_signals_list, 0)));
                   ^
1 error generated.
```

I'm not sure why, but it's easy enough to workaround it be declaring the
function that we need.

It's also a little cleaner this way as we only make the one private
function we need available rather than everything.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: cfe43bbb-bb8a-4289-a102-594ae6f6945d -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant