Skip to content

Conversation

@pljones
Copy link
Contributor

@pljones pljones commented Jun 2, 2023

Short description of changes

Bring documentation inline with latest code.

Context: Fixes an issue? Related issues

jamulussoftware/jamulus#3017 updated Jamulus to use --directoryaddress for the Directory address command line argument.

Status of this Pull Request

Text files updated.

What is missing until this pull request can be merged?

Reviews.

Does this need translation?

Probably not - this is an untranslatable string.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I'm sure that this Pull Request goes to the correct branch

@pljones pljones self-assigned this Jun 2, 2023
@pljones pljones requested review from ann0see and gilgongo June 2, 2023 20:35
@pljones pljones added the good first issue Good for newcomers label Jun 2, 2023
@pljones pljones added this to the Release 3.10.0 milestone Jun 2, 2023
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that there isn't any other location? I quickly checked if there is a Include-Server-Commands file or similar, but there isn't.

(I might run the grep later on)

@pljones
Copy link
Contributor Author

pljones commented Jun 4, 2023

Did you check that there isn't any other location? I quickly checked if there is a Include-Server-Commands file or similar, but there isn't.

(I might run the grep later on)

In jamulussoftware/jamuluswebsite it should all be covered. My original grep / sed had not limited to src - I'd also included the po files:

 sed -i -e 's/--directoryserver/--directoryaddress/g' $(grep -lr -- --directoryserver)

The grep should have been grep -lr -- --directoryserver | grep -v '/po/\|^\.git'.

@ignotus666
Copy link
Member

ignotus666 commented Jun 4, 2023

I quickly checked if there is a Include-Server-Commands file or similar, but there isn't.

It should be removed from the po file directories - I wasn't aware that this file didn't exist in wiki/en any more. It's not on Weblate so no harm done.

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Seems good then

@ann0see ann0see merged commit 83a458b into jamulussoftware:next-release Jun 6, 2023
@pljones pljones deleted the 919-directoryaddress-in-help branch June 6, 2023 17:44
@pljones pljones linked an issue Jun 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

--directoryaddress replaces the --directoryserver command line option

3 participants