Skip to content

Translations update from Hosted Weblate #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ann0see merged 6 commits into from
Oct 16, 2022
Merged

Translations update from Hosted Weblate #855

ann0see merged 6 commits into from
Oct 16, 2022

Conversation

@weblate
Copy link
Contributor

@weblate weblate commented Oct 12, 2022

@hoffie
Copy link
Member

hoffie commented Oct 12, 2022

@ignotus666, @ann0see, @pljones: Hrm, this PR contains three commits and I don't see authorship information in any of them. :(

Is there still a problem with the Github integration / squash configuration?

@ann0see
Copy link
Member

ann0see commented Oct 12, 2022

It's configured that way.

The reason behind that was that personal email gets leaked. As the the main repo has the checkbox enabled, probably enable it here too?

@weblate weblate force-pushed the weblate-jamulus-1-index branch 2 times, most recently from 6a0fb81 to 08b8cf5 Compare October 13, 2022 15:16
@trebmuh
Copy link
Member

trebmuh commented Oct 13, 2022

Remarks/questions:

  • it's a bit strange that a bunch of (French translation) files get there "last translator" field updated while there is no update in the file
  • in a bunch of other software I'm translating (or have been involved in), when a translator update a file, his name is defined as the "last translator" and the name of his predecessor is moved on a line below. I like that way since it shows the "team" and it doesn't feel that the last translator is the only one. Could we envisage to have the same system here?

trebmuh
trebmuh reviewed Oct 13, 2022
View reviewed changes
_translator-files/po/fr/Contribution.po Outdated
#: ../wiki/en/Contribution.md:15
msgid "We use [Weblate](https://hosted.weblate.org/projects/jamulus/#languages) to translate our documentation. Read about our [documentation and translation process](https://github.com/jamulussoftware/jamuluswebsite/blob/release/README.md), and [introduce yourself](https://github.com/jamulussoftware/jamulus/discussions) if you’d like to get involved."
msgstr "Nous utilisons [Weblate](https://hosted.weblate.org/projects/jamulus/#languages) pour traduire notre documentation. Lire à propos notre [processus de documentation et de traduction](https://github.com/jamulussoftware/jamuluswebsite/blob/release/README.md), et [présentez-vous](https://github.com/jamulussoftware/jamulus/discussions) si vous souhaitez vous impliquer."
msgstr "Nous utilisons [Weblate](https://hosted.weblate.org/projects/jamulus/#languages) pour traduire notre documentation. Lisez le à propos de notre [processus de documentation et de traduction](https://github.com/jamulussoftware/jamuluswebsite/blob/release/README.md), et [présentez-vous](https://github.com/jamulussoftware/jamulus/discussions) si vous souhaitez vous impliquer."
Copy link
Member

@trebmuh trebmuh Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jujudusud : ce changement me semble bizarre. Je trouve que ça ne se lit pas bien en francais : "lisez le à propos de... " ? Je pense que la version précédente était meilleure.

Copy link
Member

@jujudusud jujudusud Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trebmuh , je propose :
"Découvrez notre processus...".

@weblate weblate force-pushed the weblate-jamulus-1-index branch from 08b8cf5 to 37fef49 Compare October 13, 2022 15:34
@ignotus666
Copy link
Member

ignotus666 commented Oct 13, 2022 •
edited
Loading

@trebmuh

it's a bit strange that a bunch of (French translation) files get there "last translator" field updated while there is no update in the file
in a bunch of other software I'm translating (or have been involved in), when a translator update a file, his name is defined as the "last translator" and the name of his predecessor is moved on a line below. I like that way since it shows the "team" and it doesn't feel that the last translator is the only one. Could we envisage to have the same system here?

I'm not sure why weblate decides to update just the header section and count that as an update by "x" translator. I can only presume it's because @jujudusud opened those files in weblate even if he didn't actually edit them.

As for your second point, I've been poking around the settings and I can't see anything related. I'll try to explore it further when I get a chance.

@ignotus666
Copy link
Member

ignotus666 commented Oct 13, 2022

Another mystery is why weblate suddenly takes it upon itself to wrap text when it has a plugin enabled explicitly to prevent this. It's done it to the Korean version of "Running a Server" but none others...

@hoffie
Copy link
Member

hoffie commented Oct 13, 2022

in a bunch of other software I'm translating (or have been involved in), when a translator update a file, his name is defined as the "last translator" and the name of his predecessor is moved on a line below. I like that way since it shows the "team" and it doesn't feel that the last translator is the only one. Could we envisage to have the same system here?

Could that be this addon? https://docs.weblate.org/en/latest/admin/addons.html#contributors-in-comment

@ignotus666
Copy link
Member

ignotus666 commented Oct 13, 2022

Could that be this addon? https://docs.weblate.org/en/latest/admin/addons.html#contributors-in-comment

Looks like it, yes! @ann0see do you see any problem with adding this? I ask because it includes contributors' emails.

@trebmuh
Copy link
Member

trebmuh commented Oct 13, 2022 •
edited
Loading

Looks great, thanks for the nice finding @hoffie

@ann0see
Copy link
Member

ann0see commented Oct 13, 2022

@ignotus666 as long as my E-Mail is not on the release branch and others are ok with it, feel free to manage/install it on Weblate.

@ignotus666
Copy link
Member

ignotus666 commented Oct 13, 2022

Done.

@ann0see
Copy link
Member

ann0see commented Oct 13, 2022

Another mystery is why weblate suddenly takes it upon itself to wrap text when it has a plugin enabled explicitly to prevent this. It's done it to the Korean version of "Running a Server" but none others...

Maybe not every component has it enabled?

@weblate weblate force-pushed the weblate-jamulus-1-index branch from 37fef49 to 5812a53 Compare October 13, 2022 20:27
@ignotus666
Copy link
Member

ignotus666 commented Oct 13, 2022

I checked when I installed this last add-on and yes, it's enabled in all of them. Besides, it would have done it to all languages in that component. I just updated the Spanish translation of "Running a Server" and there's no wrapping. It's weird.

@weblate weblate force-pushed the weblate-jamulus-1-index branch 3 times, most recently from 6fc8cc8 to 3f492ba Compare October 14, 2022 19:59
@henkdegroot
Copy link
Contributor

henkdegroot commented Oct 14, 2022

This PR fixes #850

@weblate
Update translation files
b3f5346 
Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/
Translation: Jamulus/FAQ
@weblate
Update translation files
0f05e28 
Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/
Translation: Jamulus/FAQ
@weblate
Update translation files
3a14fd2 
Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/
Translation: Jamulus/FAQ
@weblate
Update translation files
014185c 
Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/
Translation: Jamulus/FAQ
@weblate
Update translation files
15bd74f 
Updated by "Squash Git commits" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/jamulus/faq/
Translation: Jamulus/FAQ
@weblate
Update translation files
bf5ccbb 
Updated by "Squash Git commits" hook in Weblate.

Translation: Jamulus/Tips-Tricks-More
Translate-URL: https://hosted.weblate.org/projects/jamulus/tips-tricks-more/
@weblate weblate force-pushed the weblate-jamulus-1-index branch from 3f492ba to bf5ccbb Compare October 16, 2022 15:26
@ann0see
Copy link
Member

ann0see commented Oct 16, 2022

Attention: I will merge this in about one hour.

@ann0see ann0see merged commit c7e1fae into jamulussoftware:next-release Oct 16, 2022
@ann0see
Copy link
Member

ann0see commented Oct 16, 2022

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trebmuh trebmuh trebmuh left review comments

@jujudusud jujudusud jujudusud left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@weblate @hoffie @ann0see @trebmuh @ignotus666 @henkdegroot @jujudusud