Remove separate ARM build #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Probably needs a rebase on my side... |
4a916b9 to
1749be9
Compare
This reverts the separate link for ARM releases
1749be9 to
0f2fb54
Compare
Contributor
|
Could do with review by a Mac owner. Preferably three Mac owners (legacy, post-legacy Intel, Apple Silicon). |
Member
Author
|
I think the binary is already tested OK. That's just a change on the website. |
Contributor
Yes. I'd like people who know what to look for to read it and see if it makes enough sense. |
gilgongo
reviewed
Sep 2, 2022
| [Download Jamulus (Apple Silicon)]({{ site.download_root_link }}{{ site.download_file_names.mac-arm }}){: .button} | ||
|
|
||
| 1. [Download Jamulus (Universal build)]({{ site.download_root_link }}{{ site.download_file_names.mac }}){: .button}\\ | ||
| **macOS Mojave (10.14) or lower:** [Download legacy version]({{ site.download_root_link }}{{ site.download_file_names.mac-legacy }})\\ |
Member
There was a problem hiding this comment.
Is "universal build" standard vocabulary for Mac users? What happens if we just give a minimum OS version?
Member
There was a problem hiding this comment.
OK well in that case it looks good to me.
gilgongo
approved these changes
Sep 3, 2022
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
As jamulussoftware/jamulus#2808 was merged, we now have a universal build making the need of separate ARM and Intel downloads for macOS unneeded
Context: Fixes an issue? Related issues
Related to: jamulussoftware/jamulus#2808
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Review
Does this need translation?
YES
Checklist