Skip to content

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Oct 25, 2022

GitHub is deprecating "set-output", thus changing it to new approac, thus changing it to new approach

Short description of changes

Needs to be tested. Especially the Windows/Python parts

CHANGELOG: SKIP

Context: Fixes an issue?

Fixes: #2937

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Test (check if all output variables are still ok)

What is missing until this pull request can be merged?

CI run

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

AUTOBUILD: Please build all targets

@ann0see ann0see added this to the Release 3.10.0 milestone Oct 25, 2022
@ann0see ann0see marked this pull request as draft October 25, 2022 20:22
@ann0see ann0see force-pushed the upgrade/removeSetOutput branch 7 times, most recently from f3ff014 to 9cbc5ef Compare October 25, 2022 20:48
@ann0see
Copy link
Member Author

ann0see commented Oct 25, 2022

@ann0see ann0see force-pushed the upgrade/removeSetOutput branch 2 times, most recently from 988505b to d0977da Compare October 25, 2022 21:00
@ann0see ann0see force-pushed the upgrade/removeSetOutput branch 3 times, most recently from 63a4399 to db7512a Compare October 25, 2022 21:08
GitHub is deprecating "set-output", thus changing it to new approac, thus changing it to new approach

Fixes: jamulussoftware#2937
@ann0see ann0see force-pushed the upgrade/removeSetOutput branch from db7512a to 5957b8d Compare October 25, 2022 21:12
@ann0see ann0see marked this pull request as ready for review October 25, 2022 21:36
@ann0see
Copy link
Member Author

ann0see commented Oct 25, 2022

iOS is probably unrelated. Seems ok now.

@hoffie
Copy link
Member

hoffie commented Oct 25, 2022

iOS is probably unrelated. Seems ok now.

Second attempt already got further.

Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's hope iOS doesn't have surprises for us (CI is unfinished at the time of writing). ;)

@ann0see ann0see merged commit 722ee6d into jamulussoftware:master Nov 4, 2022
@ann0see ann0see deleted the upgrade/removeSetOutput branch November 4, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Build: Use Github environment files instead of deprecated set-output before 2023-05-31

3 participants