Skip to content

Conversation

@ignotus666
Copy link
Member

These are the updates contained in a Weblate pull request that was closed due to weblate's branch being deleted.

CHANGELOG:

Context: Fixes an issue?

Replaces #2921

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Preferably merged soon as until then I can't unlock the newly-created component on Weblate (conflicts would probably arise if someone were to add translations to it while this hasn't been merged).

What is missing until this pull request can be merged?

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see changed the title Weblate updates Get Translations from weblate Oct 19, 2022
@ann0see
Copy link
Member

ann0see commented Oct 19, 2022

Could you please update the commit message to something like "Get translations from Weblate" or something else which is clear.

@ann0see
Copy link
Member

ann0see commented Oct 19, 2022

Ah yes, and if possible, please add the correct credits.

@ignotus666
Copy link
Member Author

Ah yes, and if possible, please add the correct credits.

How do I do that?

@hoffie
Copy link
Member

hoffie commented Oct 19, 2022

It might also be possible to fetch the original PRs commits and use those as a base.

@ignotus666
Copy link
Member Author

It might also be possible to fetch the original PRs commits and use those as a base.

Thing is, this PR is that original one + edits from Weblate that didn't make it into it.

@ann0see
Copy link
Member

ann0see commented Oct 19, 2022

As it IS possible to merge the other PR and I did it, closing this one. Thanks nevertheless!

Will look at weblate...

@ann0see ann0see closed this Oct 19, 2022
@ann0see ann0see reopened this Oct 19, 2022
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got the problem. Could you please rebase this PR?

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. (seems to be only an it update). This should then be squash merged...

@ann0see ann0see added this to the Release 3.10.0 milestone Oct 20, 2022
@ann0see
Copy link
Member

ann0see commented Dec 25, 2022

@ignotus666 how do we proceed with this PR? Can we merge it?

@ignotus666
Copy link
Member Author

I just checked and it seems the Italian app translation is at 100% on Weblate, so this PR can be closed - otherwise merging it could cause conflict chaos.

@ann0see
Copy link
Member

ann0see commented Dec 26, 2022

Ok. @dzpex @ignotus666 I’m closing this PR the.

@ann0see ann0see closed this Dec 26, 2022
@ann0see ann0see removed this from the Release 3.10.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants