-
Notifications
You must be signed in to change notification settings - Fork 238
Get Translations from weblate #2922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you please update the commit message to something like "Get translations from Weblate" or something else which is clear. |
|
Ah yes, and if possible, please add the correct credits. |
How do I do that? |
|
It might also be possible to fetch the original PRs commits and use those as a base. |
Thing is, this PR is that original one + edits from Weblate that didn't make it into it. |
|
As it IS possible to merge the other PR and I did it, closing this one. Thanks nevertheless! Will look at weblate... |
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I got the problem. Could you please rebase this PR?
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. (seems to be only an it update). This should then be squash merged...
|
@ignotus666 how do we proceed with this PR? Can we merge it? |
|
I just checked and it seems the Italian app translation is at 100% on Weblate, so this PR can be closed - otherwise merging it could cause conflict chaos. |
|
Ok. @dzpex @ignotus666 I’m closing this PR the. |
These are the updates contained in a Weblate pull request that was closed due to weblate's branch being deleted.
CHANGELOG:
Context: Fixes an issue?
Replaces #2921
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Preferably merged soon as until then I can't unlock the newly-created component on Weblate (conflicts would probably arise if someone were to add translations to it while this hasn't been merged).
What is missing until this pull request can be merged?
Checklist