Refactoring: Move Linux distribution/ files to linux/ #2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
reviewed
Sep 5, 2022
38ab6fb to
c012232
Compare
pljones
approved these changes
Sep 5, 2022
Member
Author
|
Yes, this still needs some investigation. |
Member
Author
|
I think I know what happened. The branch is NOT ok: the debian folder got lost |
c012232 to
5904a78
Compare
pljones
reviewed
Sep 6, 2022
pljones
reviewed
Sep 6, 2022
5904a78 to
0f5aeb7
Compare
pljones
approved these changes
Sep 6, 2022
Collaborator
pljones
left a comment
There was a problem hiding this comment.
Looks like it's only the dependeny issue again, now.
Member
Author
|
It looks ok on Debian too. @corrados should know that this Pull Request moves raspijamulus.sh to the linux/ folder. In future we might move it again, depending on the restructuring of the repo layout. |
5 tasks
Contributor
Thanks for letting me know. It's totally fine with me :-). |
hoffie
approved these changes
Sep 6, 2022
Member
hoffie
left a comment
There was a problem hiding this comment.
After careful diff scanning, this looks fine to me... :)
Member
Author
|
Thanks @corrados for your OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Moves Linux distribution files to linux/ folder and icons to src/res. We might even be able to reuse some of the images now.
CHANGELOG: Refactoring: Moved around files to clean up the repository
Context: Fixes an issue?
Related to: #2601
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
To be tested on Raspberry Pi with raspijamulus
What is missing until this pull request can be merged?
Review and decision on the weather we rename deb-mainicon.* to deb-jamulus.* since that's describing more what the file actually is. However that would break the naming style of Windows and macOS icons.
Checklist