Github: Fix bump-dependencies runs on existing PRs & adjust title #2801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow got permission errors from the Github API when trying to edit existing PRs which had already been added to an organization project. The reason for this is that the GITHUB_TOKEN of the run is scoped to the repo, but `gh edit` tries to fetch all fields of a PR which includes the inaccessible organization project field. Therefore, use `gh api` instead which can be used in a more fine-grained way. Fixes: jamulussoftware#2777 (comment)
This was referenced Aug 22, 2022
pljones
reviewed
Aug 26, 2022
pljones
approved these changes
Aug 28, 2022
ann0see
approved these changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
The bump-dependencies workflow got permission errors from the Github API when trying to edit existing PRs which had already been added to an organization project.
The reason for this is that the GITHUB_TOKEN of the run is scoped to the repo, but
gh edittries to fetch all fields of a PR which includes the inaccessible organization project field. Therefore, usegh apiinstead which can be used in a more fine-grainedway.
This PR also addresses @ann0see's request to mimic the dependabot commit message style.
Group with:
CHANGELOG: Internal: Enabled automated dependency updates via dependabot and custom automation
Context: Fixes an issue?
Fixes: #2777 (comment)
Fixes: #2787 (comment)
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
Reviews.
Checklist