Scripts: Set -o pipefail #2794
Merged
Scripts: Set -o pipefail #2794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Testable tooling (e.g. translation checker, copyright updates) tested. All scripts reviewed for potential unwanted side effects (little pipe usage and where pipes are used, they should be checked properly). The Linux CI failure is expected and is a proof of this change working properly. It will go once #2793 is merged and the PR is rebased. |
pljones
approved these changes
Aug 22, 2022
Member
|
I think you should now rebase this PR? |
This is supposed to avoid silent failures when using pipes.
451cca1 to
95b6ae7
Compare
Member
Author
|
Rebased. Linux builds are green now as well, as expected. |
ann0see
approved these changes
Aug 22, 2022
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
This is supposed to avoid silent failures when using pipes.
Example: #2793 (https://github.com/hoffie/jamulus/runs/7930874876?check_suite_focus=true#step:9:42)
CHANGELOG: Internal: Hardened build scripts and tooling against silent failures.
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist