Skip to content

Export NDK root #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pljones merged 1 commit into from
Aug 1, 2022
Merged

Export NDK root #2764

pljones merged 1 commit into from
Aug 1, 2022

Conversation

@pljones
Copy link
Collaborator

@pljones pljones commented Jul 30, 2022 •
edited
Loading

Short description of changes

Fixes failing Android build.

Context: Fixes an issue?

Fixes failing Android build.

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Android build attached to 3.9.0 release.

What is missing until this pull request can be merged?

Confirmation from someone other than me that it works ("worked for me").

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones pljones requested a review from hoffie July 30, 2022 17:42
@pljones
Copy link
Collaborator Author

pljones commented Jul 30, 2022

I'd also strongly suggest moving off Java 8 onto the latest release that Github supports.

ann0see
ann0see approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes it's that easy...

Yes, we can move off java 8, but not for 3.9.0. Ok I just saw that you already released the apk.

hoffie
hoffie approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is now required to be exported, that's fine. When I last touched this logic, I was aiming to only export what's necessary in order to have a clearer boundary.
Either requirements have changed or it happened to work by accident due to similar versions between us and GH (which would mean that the previous code was wrong anyway).

@hoffie
Copy link
Member

hoffie commented Aug 1, 2022

I'd also strongly suggest moving off Java 8 onto the latest release that Github supports.

Seconded, but I think that certain Android build tools require certain Java versions. Updating Java might imply updating other components which might imply dropping support for older platform levels, so we should check closely.

@pljones pljones merged commit b041f91 into jamulussoftware:master Aug 1, 2022
@pljones pljones deleted the r3_9_0-android-1 branch August 1, 2022 15:33
@pljones pljones mentioned this pull request Aug 1, 2022
Open
@pljones pljones added this to the Release 3.9.1 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoffie hoffie hoffie approved these changes

@ann0see ann0see ann0see approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Tracking
Status: Done

Milestone

Release 3.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@pljones @hoffie @ann0see