Skip to content

Partly update de_DE app translation for r3.9.0 #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pljones merged 1 commit into from
Jul 23, 2022
Merged

Partly update de_DE app translation for r3.9.0 #2748

pljones merged 1 commit into from
Jul 23, 2022

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Jul 22, 2022 •
edited
Loading

Short description of changes

Only includes the most important translations for German due to missing translator

CHANGELOG: Partly updated German translation for release 3.9.0
Context: Fixes an issue?
Fixes: #2692

Does this change need documentation? What needs to be documented and how?
NO

Status of this Pull Request
Ready for review

What is missing until this pull request can be merged?
Review by native German speaker.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added this to the Release 3.9.0 milestone Jul 22, 2022
@ann0see
Copy link
Member Author

ann0see commented Jul 22, 2022 •
edited
Loading

Review Checklist:

  • Translator listed in the src/util.cpp (Yes. )
  • Punctuation and spacing consistent (should be verified by someone else)
  • Signal words consistent ("ASIO", "Buffer")
  • App translations: No untranslated strings (grep unfinished -5 src/translation/translation_$TRANSLATION*.ts) (leaving up to rolamos)
  • App translations: Only a single .ts file checked in (.qm in addition is also OK)

@ann0see ann0see force-pushed the translation_de_DE-r3.9.0 branch 2 times, most recently from c8252ae to e506f0b Compare July 22, 2022 19:01
@ann0see ann0see marked this pull request as ready for review July 22, 2022 19:02
@ann0see ann0see requested a review from hoffie July 22, 2022 19:02
@ann0see ann0see changed the title Partly update de_DE for r3.9.0 Partly update de_DE app translation for r3.9.0 Jul 22, 2022
@ann0see ann0see force-pushed the translation_de_DE-r3.9.0 branch from e506f0b to 2348860 Compare July 22, 2022 19:04
@ann0see ann0see requested a review from pljones July 22, 2022 19:22
pljones
pljones reviewed Jul 22, 2022
View reviewed changes
@pljones pljones added the translation used by tools/create-translation-issues.sh label Jul 22, 2022
@pljones pljones mentioned this pull request Jul 23, 2022
Closed
75 tasks
@ann0see
Partly update de_DE app translation for 3.9.0
28b5836 
Only includes the most important translations for German due to missing 
translator

Fixes: jamulussoftware#2692
@ann0see ann0see force-pushed the translation_de_DE-r3.9.0 branch from 2348860 to 28b5836 Compare July 23, 2022 11:06
@pljones pljones merged commit 413de2a into jamulussoftware:master Jul 23, 2022
@ann0see ann0see deleted the translation_de_DE-r3.9.0 branch July 23, 2022 16:01
@ann0see ann0see restored the translation_de_DE-r3.9.0 branch July 23, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pljones pljones pljones approved these changes

@hoffie hoffie Awaiting requested review from hoffie

Assignees

No one assigned

Labels

translation used by tools/create-translation-issues.sh

Projects

None yet

Milestone

Release 3.9.0

Development

Successfully merging this pull request may close these issues.

Update de_DE app translation for 3.9.0

2 participants

@ann0see @pljones