-
Notifications
You must be signed in to change notification settings - Fork 238
Update sk_SK app translation for 3.9.0 #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Translator listed in the
src/util.cppLine 736 in fa204ad
"<p>Jose Riha (<a href=\"https://github.com/jose1711\">jose1711</a>)</p>" + - Punctuation and spacing consistent
- Signal words consistent ("ASIO", "Buffer")
- App translations: No untranslated strings (
grep unfinished -5 src/translation/translation_$TRANSLATION*.ts) (there are some) - App translations: Only a single
.tsfile checked in (.qmin addition is also OK)
|
There are unfinished translations: Do you plan to translate them for this release? |
|
You should rebase this Pull request as described here to fix the conflicts: https://github.com/jamulussoftware/jamulus/blob/master/docs/TRANSLATING.md#updating-a-prfixing-conflicts |
17cbc87 to
b0bb053
Compare
No, no further plans. |
Removed |
|
Please don’t remove the qm file. (Doing so breaks the build). Since you rebased the PR you should be able to re generate it. |
Done. |
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Thanks. Approving since Checklist is ok and CI green.
pljones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't read Polish at all but approving.
Fixes #2700