#2720 Add libQt5Multimedia5 dependency to deb control #2721
Conversation
ann0see
left a comment
There was a problem hiding this comment.
We need to check this on old Ubuntu versions too. 18.something
Ah yeah... mm, let me see... Mmm... 5.9.5 according to https://packages.ubuntu.com/bionic/libs/ - I'll change it. Actually, we're very mix'n'match. Rather than 5.9.5 for everything, we start at libqt5core5a (>= 5.5.0) then drop down to 5.0.2 for network, xml and gui and bump to 5.2.0 for widgets... Should we stick with 5.5.0? Or move everything to 5.9.5 (and update the headless dependencies to match)? |
|
I think there's a reason for it. The GitHub build is somewhat inconsistent. We need to support Debian old-stable at least and the respective Ubuntu version.
|
We're way, way behind Debian stretch, which is their oldest listed version, in some of these. They're on Qt 5.7.1 there. |
|
Well, it's not failing to pull the dependencies... Did I do that..? |
22d0e94 to
473c8ee
Compare
|
Just to note: one of the reasons we should ("must") keep our dependency versions updated is to keep on secure (i.e. maintained) versions. Many of the dependencies we're listing now are out of support. Perhaps that could be part of the release process: make sure the |
Works for me. But then, I'd manually installed libQt5multimedia5 for build purposes... |
|
I just installed it on a amd64 Raspbian VM with GUI and it pulled ~200-300mb dependencies. I'm not sure if that's really all needed. |
Flatten the VM, install buster or ubuntu 18 with a Qt based desktop, then install 3.8.2. Then install this one. Does it still fetch new things? For headless, similarly, flatten, install buster or ubuntu 18 without a desktop, install 3.8.2 first, then this one. |
|
Ok. A clean Debian 10 with lxqt doesn't install any more dependencies for this .deb. I assume that's due to the Destktop environment. Probably it's worth checking a non qt DE. |
Yep - but 3.8.2 first, still. |
|
3.8.2 just installed around 20mb so it seems to be ok on LXQT |
|
Headless on a headless debian 10 machine:
XFCE4:
So it seems to work as expected (although IDK why it installs python). Probably something went wrong on my end (I'm using Gnome on my laptop) |
|
@reinhardwh since you reported #2422 I assume you run Ubuntu 18.04 somewhere (maybe not only on a server?). Could you please check - if you can install the app with GUI, how many dependencies this would pull in, if you also run Ubuntu an a machine with GUI? |
|
Did you install 3.8.2 RELEASE first? We want to see the change. |
|
Sorry. I did only on Debian 11, I think. But let me try that again (comment will follow) However Ubuntu 18.04 is now broken: libqt5multimedia5 doesn't exist on Ubuntu 18.04, at least apt install libqt5multimedia5 says so. However: https://packages.ubuntu.com/bionic/libqt5multimedia5 says it does. |
Not running 18.04 on my server anymore. Upgraded my server to LTS 20.04 |
|
First install of jamulus 3.8.2 on Debian 10.12
Now the .deb from this PR
@reinhardwh thanks for your comment! |
|
The upgrade looks sane - add qt5multimedia5 and you get it and its dependencies. |
This one is strange, though... Maybe Ubuntu never made 5.9.5 available on their repos. Might have to use a later version, after all. Can you do |
That's what ldd jamulus from 3.8.2 release gives. I don't see which Qt version it uses. I couldn't find it in the build logs on GitHub either. |
|
If you then do except with lower version numbers. (I made a mistake - I didn't need the |
|
@mirabilos, a little due diligence confirmation, please. Should I be worried that I don't see libc6, libstdc++6, libgcc1 and libjack-jackd2-0 don't say "+dfsg" either (but maybe their licences don't need specifying as part of the version). |
|
Peter L Jones dixit:
***@***.***, a little due diligence confirmation, please.
```
***@***.***:~/git/Jamulus-wip$ apt list libqt5*5* | grep dfsg | grep 'libqt5core5a\|libqt5network5\|libqt5xml5\|libqt5gui5\|libqt5gui5-gles\|libqt5widgets5\|libqt5multimedia5'
WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
Better tool:
$ rmadison -u qa libqt5multimedia5
libqt5multimedia5 | 5.3.2-5~bpo70+1 | wheezy-backports | amd64, armel, armhf, i386, mips, mipsel, powerpc, s390x, sparc
libqt5multimedia5 | 5.3.2-5 | jessie | amd64, armel, armhf, i386
libqt5multimedia5 | 5.7.1~20161021-2 | stretch | amd64, arm64, armel, armhf, i386, mips, mips64el, mipsel, ppc64el, s390x
libqt5multimedia5 | 5.11.3-2 | buster | amd64, arm64, armel, armhf, i386, mips, mips64el, mipsel, ppc64el, s390x
libqt5multimedia5 | 5.15.2-3 | bullseye | amd64, arm64, armel, armhf, i386, mips64el, mipsel, ppc64el, s390x
libqt5multimedia5 | 5.15.4-2 | bookworm | amd64, arm64, armel, armhf, i386, mips64el, mipsel, ppc64el, s390x
libqt5multimedia5 | 5.15.4-2 | sid | amd64, arm64, armel, armhf, i386, mips64el, mipsel, ppc64el, s390x
$ rmadison -u ubuntu libqt5multimedia5
libqt5multimedia5 | 5.2.1-0ubuntu5 | trusty | amd64, arm64, armhf, i386, powerpc, ppc64el
libqt5multimedia5 | 5.5.1-4ubuntu2 | xenial | amd64, arm64, armhf, i386, powerpc, ppc64el, s390x
libqt5multimedia5 | 5.9.5-0ubuntu1 | bionic/universe | amd64, arm64, armhf, i386, ppc64el, s390x
libqt5multimedia5 | 5.12.8-0ubuntu1 | focal/universe | amd64, arm64, armhf, i386, ppc64el, riscv64, s390x
libqt5multimedia5 | 5.15.2-3 | impish/universe | amd64, arm64, armhf, i386, ppc64el, riscv64, s390x
libqt5multimedia5 | 5.15.3-1 | jammy/universe | amd64, arm64, armhf, i386, ppc64el, riscv64, s390x
libqt5multimedia5 | 5.15.4-2 | kinetic/universe | amd64, arm64, armhf, i386, ppc64el, riscv64, s390x
And to check Debian-Ports architectures you need the source package name:
https://buildd.debian.org/status/package.php?p=qtmultimedia-opensource-src
Should I be worried that I don't see `libqt5multimedia5` listed with a `+dfsg` version?
No. The +dfsg just means that the upstream source contains nōn-free
artefacts that need to be removed by repacking.
bye,
//mirabilos
--
I believe no one can invent an algorithm. One just happens to hit upon it
when God enlightens him. Or only God invents algorithms, we merely copy them.
If you don't believe in God, just consider God as Nature if you won't deny
existence. -- Coywolf Qi Hunt
|
|
@ann0see did you get a chance to look at this yet?
|
|
Will try soon, holidays are over ;-) |
|
|
|
OK, so looks like 5.9.5 is good. |
|
So it's another issue? |
|
Hm. Can you run on a "clean" VM without Jamulus? Then install 3.8.2 release and run again, please. |
|
Before 3.8.2 install
After install: |
|
OK, so no trace of libqt5multimedia5 and only libqt5xml5 getting installed (the others look like they updated). OK, thanks. Hm. OK, I think I've found the problem. Note Here, the package archive is Now the question is what to do about it... |
|
OK, what I think we need to do is this:
|
|
@ann0see Can you try adding universe on the VM and seeing if that does, indeed, resolve it? If it does, I'll raise a separate bug for changing the documentation and we'll need to include it in the release note. |
|
Hi @gilgongo, Could you also check whether you've got universe enabled and what the output of gives, please. Can you confirm the build here does work without further issues on your Ubuntu 22 system? Thanks. |
473c8ee to
477afef
Compare
|
Installation works fine in a 22.04 container. However, the library comes from universe on 22.04 as well. :( Not sure what the best path forward is:
Options:
cc @chigkim |
|
Ok. I can confirm that adding universe does fix it. I'd be ok with
and
but tend towards 1 and a simple documentation change. |
477afef to
7dcf239
Compare
|
Yep, I think we should add to the "How to install" page for Linux Client: You will need to enable the "universe" Ubuntu repository before installing. Please see one of the following two posts: (Debian doesn't have "universe", only "main", "contrib" and "non-free". It appears to be in main: https://debian.pkgs.org/10/debian-main-amd64/libqt5multimedia5_5.11.3-2_amd64.deb.html) jamulussoftware/jamuluswebsite#781 raised for the simple documentation change. |
Short description of changes
Adds libQt5Multimedia5 dependency to distributions/debian/control.
CHANGELOG: Ubuntu: Added new runtime dependendency. You will need to add the "universe" apt repository (on Ubuntu only)
Context: Fixes an issue?
Fixes: #2720
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
I'll run the Git build once it's ready to see if it's fixed.
What is missing until this pull request can be merged?
Testing...
Checklist