-
Notifications
You must be signed in to change notification settings - Fork 238
Update nl_NL app translation for 3.9.0 #2708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nl_NL app translation for 3.9.0 #2708
Conversation
|
@jerogee, ready for review. |
src/translation/translation_nl_NL.ts
Outdated
| </message> | ||
| <message> | ||
| <location filename="../serverdlg.cpp" line="737"/> | ||
| <source>Now a directory server</source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, as I mentioned in the French translation, can you avoid "server" where you see "directory server" in English - the English needs updating.
(And, indeed, if you could change all such existing translations... that'd be great!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason why I include "server" is because the English text contains it. WIll update the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pljones only found two strings that needed updating.
The strings which still include "server" are marked as vanished, so have not update those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, sounds like the Dutch has been kept up to date with the English, then. I think you can delete anything marked "vanished" (but someone else should confirm).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anything marked
"vanished"(but someone else should confirm).
I agree, "vanished" should be possible to be removed. I even believe we should look at cleaning up the .ts files post release, so that during the release the translator can make use of the vanished strings (in case needed) and then after the release a cleanup (script) is run to remove the vanished strings from all langauge files. After all this only requires to use an extra option with the lupdate command (-noobsolete) to have them removed.
Or instead of post release, it can be part of the create release process as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you avoid "server" where you see "directory server" in English - the English needs updating
Changing translations to make them "correct" before the English version has been corrected is the wrong way to go about it. When the English text is finally updated, those strings will be marked as "untranslated" in the translations, making it necessary to edit them yet again anyway. It's better to merge #2709 now and then tell translators to update their files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right - I didn't realise that. Thanks!
e7ad12b to
ef4d541
Compare
jerogee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All translation strings in Dutch look fine and consistent.
ef4d541 to
b71f40c
Compare
|
@jerogee, a change was made to the source which required the translation to be updated. I can you confirm you are still happy with the NL update? |
|
@henkdegroot , I noticed the new changes, which look correctly translated. Good to go! |
|
Short description of changes
Updating the nl_NL application translation for 3.9.0 version.
CHANGELOG: Update nl_NL app translation for 3.9.0
Context: Fixes an issue?
Fixes #2696
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Checklist