Skip to content

Conversation

@henkdegroot
Copy link
Contributor

@henkdegroot henkdegroot commented Jul 4, 2022

Short description of changes
Updating the nl_NL application translation for 3.9.0 version.

CHANGELOG: Update nl_NL app translation for 3.9.0

Context: Fixes an issue?
Fixes #2696

Does this change need documentation? What needs to be documented and how?
No

Status of this Pull Request
Ready for review

What is missing until this pull request can be merged?

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@henkdegroot henkdegroot requested review from jerogee July 4, 2022 20:28
@henkdegroot
Copy link
Contributor Author

@jerogee, ready for review.

@henkdegroot henkdegroot added translation used by tools/create-translation-issues.sh labels Jul 4, 2022
@henkdegroot henkdegroot modified the milestone: Release 3.9.0 Jul 4, 2022
</message>
<message>
<location filename="../serverdlg.cpp" line="737"/>
<source>Now a directory server</source>
Copy link
Collaborator

@pljones pljones Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, as I mentioned in the French translation, can you avoid "server" where you see "directory server" in English - the English needs updating.

(And, indeed, if you could change all such existing translations... that'd be great!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason why I include "server" is because the English text contains it. WIll update the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pljones only found two strings that needed updating.

The strings which still include "server" are marked as vanished, so have not update those.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, sounds like the Dutch has been kept up to date with the English, then. I think you can delete anything marked "vanished" (but someone else should confirm).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything marked "vanished" (but someone else should confirm).

I agree, "vanished" should be possible to be removed. I even believe we should look at cleaning up the .ts files post release, so that during the release the translator can make use of the vanished strings (in case needed) and then after the release a cleanup (script) is run to remove the vanished strings from all langauge files. After all this only requires to use an extra option with the lupdate command (-noobsolete) to have them removed.
Or instead of post release, it can be part of the create release process as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you avoid "server" where you see "directory server" in English - the English needs updating

Changing translations to make them "correct" before the English version has been corrected is the wrong way to go about it. When the English text is finally updated, those strings will be marked as "untranslated" in the translations, making it necessary to edit them yet again anyway. It's better to merge #2709 now and then tell translators to update their files.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right - I didn't realise that. Thanks!

@henkdegroot henkdegroot force-pushed the translate-r3_9_0-dutch branch from e7ad12b to ef4d541 Compare July 4, 2022 20:57
Copy link
Contributor

@jerogee jerogee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All translation strings in Dutch look fine and consistent.

@henkdegroot henkdegroot force-pushed the translate-r3_9_0-dutch branch from ef4d541 to b71f40c Compare July 6, 2022 06:14
@henkdegroot
Copy link
Contributor Author

@jerogee, a change was made to the source which required the translation to be updated. I can you confirm you are still happy with the NL update?

@jerogee
Copy link
Contributor

jerogee commented Jul 6, 2022

@henkdegroot , I noticed the new changes, which look correctly translated. Good to go!

@ann0see
Copy link
Member

ann0see commented Jul 6, 2022

  • Translator listed in the src/util.cpp
  • Punctuation and spacing consistent (todo)
  • Signal words consistent ("ASIO", "Buffer") (todo)
  • No untranslated strings (grep unfinished -5 src/res/translation/translation_$TRANSLTION*.ts)
  • Only a single .ts file checked in (+ Installer translations)

@ann0see ann0see merged commit fe47ddd into jamulussoftware:master Jul 6, 2022
@ann0see ann0see mentioned this pull request Jul 6, 2022
75 tasks
@henkdegroot henkdegroot deleted the translate-r3_9_0-dutch branch July 7, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation used by tools/create-translation-issues.sh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update nl_NL app translation for 3.9.0

5 participants