COMPILING.md: Add table for compile time arguments #2707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
reviewed
Jul 4, 2022
Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
pljones
approved these changes
Jul 5, 2022
hoffie
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Add a list for supported compile time optimistic COMPILING.md. This especially documents the nojsonrpc build option
CHANGELOG: Documentation: Document compile time options to COMPILING.md
Context: Fixes an issue?
No. however this removes the needs documentation label of #2660 (I don’t think we habe anything related to the compilation of the server on the website anymore)
Does this change need documentation? What needs to be documented and how?
No. It is documentation 😀
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Review by @gilgongo or @pljones
Checklist