Skip to content

#2335 Rephrase mute options in help text #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ann0see merged 1 commit into from
Jun 28, 2022
Merged

#2335 Rephrase mute options in help text #2673

ann0see merged 1 commit into from
Jun 28, 2022

Conversation

@pljones
Copy link
Collaborator

@pljones pljones commented Jun 25, 2022 •
edited
Loading

Short description of changes

Rephrases the mute options in help text

CHANGELOG: Rephrase mute options in help text

Context:
Fixes: #2335

Does this change need documentation? What needs to be documented and how?

Website help must be in line with application help.

Status of this Pull Request

Tested locally.

What is missing until this pull request can be merged?

Sign off

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones pljones added this to the Release 3.9.0 milestone Jun 25, 2022
@pljones pljones self-assigned this Jun 25, 2022
@ann0see ann0see requested review from ann0see and gilgongo June 25, 2022 15:31
ann0see
ann0see reviewed Jun 25, 2022
View reviewed changes
@pljones pljones force-pushed the bugfix/#2335-rephrase-mute-options-in-help-text branch 2 times, most recently from 93f5de8 to 3ede70e Compare June 25, 2022 21:16
@pljones pljones force-pushed the bugfix/#2335-rephrase-mute-options-in-help-text branch from 3ede70e to d47a953 Compare June 25, 2022 21:20
ann0see
ann0see reviewed Jun 26, 2022
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Waiting on @gilgongo for a final word.

@ann0see ann0see merged commit 65c23ba into jamulussoftware:master Jun 28, 2022
@ann0see
Copy link
Member

ann0see commented Jun 28, 2022

@gilgongo you can review this PR and open a new one if anything else is needed. For sure, the website needs to be updated too.

@ann0see ann0see added the needs documentation PRs requiring documentation changes or additions label Jun 28, 2022
@pljones pljones deleted the bugfix/#2335-rephrase-mute-options-in-help-text branch June 28, 2022 15:42
@gilgongo gilgongo mentioned this pull request Jul 10, 2022
Merged
@gilgongo gilgongo removed the needs documentation PRs requiring documentation changes or additions label Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoffie hoffie hoffie approved these changes

@ann0see ann0see ann0see approved these changes

@gilgongo gilgongo Awaiting requested review from gilgongo

Assignees

@pljones pljones

Labels

None yet

Projects

None yet

Milestone

Release 3.9.0

Development

Successfully merging this pull request may close these issues.

Rephrase mute options in help text

4 participants

@pljones @ann0see @hoffie @gilgongo