Well, I can't find any issue for this merging though,
If it would be failed again, I should find other way.

You need to edit the file on The branch you‘ve raised this Pull request (short form: PR or MR) from.

I‘d suggest to read https://www.freecodecamp.org/news/what-is-git-and-how-to-use-it-c341b049ae61/

and https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md to get a bit used to GitHub and git since it can get really confusing at the beginning of you start participating in an open source project.

OK! all checks have passed now it just need 2 review.
two Jamulus member can review this.

Yes. But it won't show up. You still need the other file to be changed

I think it can be done after 2 reviews and merging next PR
#2670

It should happen in one PR to allow testing.

You should be able to use the following link to edit the mentioned file and it should show up here.

https://github.com/bagjunggyu/jamulus/blob/master/src/translation/wininstaller/installerlng.nsi

OK, Thanks.
now, I did it.

Could you please test if the translation shows up correctly? You can get the installer from the "Checks" tab on this PR. You should find the "artifacts" on the bottom of that page which are the built versions of Jamulus including your changes.

Afterwards uninstall Jamulus manually and install it again via your downloaded installer. You need to uninstall it first to be able to change the language during setup.

Please take some screenshots of the pages and check if the layout is ok.

wow! this is strange though, anyway it worked :)
I can see Korean in installer.

Looks good. What’s strange? The ASIO warning? Maybe that’s a bug although I‘ve never seen it occur if an ASIO Driver was installed.

But back on topic: would you like to be mentioned as translator in the app?

@BLumia Do you know Korean?

@BLumia Do you know Korean?

Sorry I don't know Korean 😂

@BLumia Good to know. It would be good to have a reviewer/proof/partner reader for Korean to spot mistakes/give tips/ask questions etc. Would you (@chanjin65) mind reviewing this Pull Request with @bagjunggyu

Since, It doesn't seem to be merged yet. but, it worked :)
Anyway, thank you for about mentioning me as a translator in the app.

Yes, merging might take a bit (we're not that efficient in bringing PRs in quickly.) I'm quite sure that it'll be merged in the coming days.

CHANGELOG: Translated Windows installer into Korean

The last step would be to add you @bagjunggyu as translator to the app. If you want, you can add yourself to this file: https://github.com/jamulussoftware/jamulus/edit/master/src/util.cpp#L686

@hoffie @pljones somehow the Changelog didn't get the full entry.