Autobuild: Fix Mac/Windows cache key #2642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache key calculation still tried to consume the old, no longer existing build scripts contents for Mac/Windows. This wasn't noticed as the hashFiles() function ignores missing files silently. Correctness has now been verified via: `for f in $(grep -Pho 'hashFiles\(\K.*(?=\))' .github/workflows/* | sed -re 's#[^a-z0-9./_ ]##g'); do [[ -f $f ]] || echo "$f doesnt exit"; done` Broken-in: jamulussoftware#2503
5 tasks
pljones
approved these changes
May 25, 2022
ann0see
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
The cache key calculation still tried to consume the old, no longer existing build scripts contents for Mac/Windows. This wasn't noticed as the hashFiles() function ignores missing files silently.
This caused usage of cached dependencies even when the workflow scripts had changed. As such, those changes were not visible and the build was broken. #2640 was affected by this.
Correctness has now been verified via:
for f in $(grep -Pho 'hashFiles\(\K.*(?=\))' .github/workflows/* | sed -re 's#[^a-z0-9./_ ]##g'); do [[ -f $f ]] || echo "$f doesnt exit"; doneBroken-in: #2503
CHANGELOG: (List as part of Autobuild refactorings, #2503)
Context: Fixes an issue?
#2640 (comment)
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Waiting for CI green.
What is missing until this pull request can be merged?
Reviews.
Checklist