Autobuild: Fix iOS artifact name #2619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file is currently named *Unsigned1.ipa. The 1 doesn't belong there and has wrongfully been added as part of the refactoring in f460f5c.
ann0see
approved these changes
Apr 26, 2022
Member
ann0see
left a comment
There was a problem hiding this comment.
Yeah. Noticed that too. Thanks for fixing
Member
|
ADMIN MERGED. |
Member
|
I think this should be changelog skipped. Another idea would be changelog: condense # which is taken up by the script |
Collaborator
|
On the ChangeLog, I'd take the following approach:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
The file is currently named *Unsigned1.ipa. The 1 doesn't belong there and has wrongfully been added as part of the refactoring in f460f5c.
Note: As this is a trivial fix I'll likely merge this as soon as there's a single approval.
CHANGELOG: (No extra mention; list it with the iOS refactoring PR #2521)
Context: Fixes an issue?
No Github Issue.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready on CI green.
What is missing until this pull request can be merged?
CI/Reviews.
Checklist