Skip to content

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Apr 14, 2022

Short description of changes

Updates aqt to the latest version

CHANGELOG: Internal: Updated aqt to v2.1.0 due to reliability reasons

Context: Fixes an issue?

Not really, but includes @hoffie 's updated mirror list.

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Ready for review

What is missing until this pull request can be merged?

Just an autobuild test.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want (will be done via CI)
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see requested a review from hoffie April 14, 2022 20:39
@ann0see ann0see force-pushed the patch/updateAqt branch 2 times, most recently from 59d14e6 to 4882cd2 Compare April 14, 2022 20:40
@ann0see ann0see changed the title Update aqt Update aqt to v2.1.0 Apr 14, 2022
@ann0see ann0see added this to the Release 3.9.0 milestone Apr 14, 2022
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You beat me to it... :)

Note: CodeQL is in a state which I've never seen, but I don't think it can be related to this PR.

@pljones
Copy link
Collaborator

pljones commented Apr 17, 2022

Has CodeQL got out of sync somehow? The MacOS Legacy build ran the CodeQL check -- is that right? Is a rebase needed?

@ann0see
Copy link
Member Author

ann0see commented Apr 17, 2022

Rebased. Let's have a look what CodeQl does.

@ann0see
Copy link
Member Author

ann0see commented Apr 17, 2022

The MacOS Legacy build ran the CodeQL check -- is that right?

Yes. That should be ok due to the signing issue we tried to fix?

@pljones
Copy link
Collaborator

pljones commented Apr 17, 2022

Better :)

@ann0see ann0see merged commit 20e43f9 into jamulussoftware:master Apr 17, 2022
@ann0see ann0see deleted the patch/updateAqt branch April 17, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants