Skip to content

Mac: Enable read-write files entitlement for sandbox #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
softins merged 1 commit into from
Mar 30, 2022
Merged

Mac: Enable read-write files entitlement for sandbox #2565

softins merged 1 commit into from
Mar 30, 2022

Conversation

@softins
Copy link
Member

@softins softins commented Mar 29, 2022 •
edited
Loading

Short description of changes

Adds entitlements to the app under macOS to access the filesystem as needed, via the Load/Save dialogs, to allow Mixer Channel Setup to be saved and loaded.

CHANGELOG: Mac: Fixed non-working Save/Load Mixer Channel Setup

Context: Fixes an issue?

Fixes: #2560
Replaces: #2563

Does this change need documentation? What needs to be documented and how?

No, bug fix only.

Status of this Pull Request

Should be working

What is missing until this pull request can be merged?

Check the built and signed artifact for Mac

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@softins
Copy link
Member Author

softins commented Mar 29, 2022

Build succeeded in CI, but didn't include Mac signing. Maybe it needs to be invoked by @emlynmac ?

@emlynmac
Copy link
Contributor

emlynmac commented Mar 29, 2022

@softins Yeah, you won't get signing except in my fork as that's where the secrets are.

The original PR works just fine, so I don't see why this wouldn't.
Shame that one got closed; surely it's just a permissions thing preventing the reopening?

@softins
Copy link
Member Author

softins commented Mar 29, 2022 •
edited
Loading

Shame that one got closed; surely it's just a permissions thing preventing the reopening?

No, it's because I force-pushed to your branch while the PR was still closed. That must have broken some kind of link. I should have re-opened first, before pushing anything. Learnt something.

Or possibly because the PR was already closed when you rebased and pushed. Either way, the same reason.

@emlynmac
Copy link
Contributor

emlynmac commented Mar 29, 2022

It might also be because I rebased that branch to master after the merge of the Mac entitlements move. Did you pull those first?

@softins
Copy link
Member Author

softins commented Mar 29, 2022

Yes, I did update from your repo, but because I didn't want the codeql experiments to get merged into master, I made them a separate backup branch for reference, and then reset the autobuild/bugfix-2560 to be just the entitlement change and rebased it onto the latest master that contained the CodeQL changes. If you fetch from your origin, you should see the backup branch I created.

@emlynmac
Copy link
Contributor

emlynmac commented Mar 29, 2022

So you should be good then:
https://github.com/emlynmac/jamulus/actions/runs/2061291313 has the build from my repo for the branch you made, which should have been signed.
Additionally, the main jamulus repo will build on the PR too.

ann0see
ann0see approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash merging is probably required

@hoffie hoffie added this to the Release 3.9.0 milestone Mar 30, 2022
hoffie
hoffie approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emlynmac and @softins.

@softins Yes, please squash to a single commit with a condensed title/explanation.

@hoffie hoffie changed the title Enable read-write files entitlement for sandbox Mac: Enable read-write files entitlement for sandbox Mar 30, 2022
@softins softins force-pushed the autobuild/bugfix-2560 branch from aaf3af5 to 2586189 Compare March 30, 2022 09:34
@emlynmac @softins
Mac: Enable read-write files entitlement for sandbox
771c629 
Adds entitlements to the app under macOS to access the filesystem as needed,
via the Load/Save dialogs, to allow Mixer Channel Setup to be saved and loaded.
Fixes: jamulussoftware#2560
@softins softins force-pushed the autobuild/bugfix-2560 branch from 2586189 to 771c629 Compare March 30, 2022 09:36
@softins softins merged commit a9deb22 into jamulussoftware:master Mar 30, 2022
@ann0see ann0see deleted the autobuild/bugfix-2560 branch March 30, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoffie hoffie hoffie approved these changes

@ann0see ann0see ann0see approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 3.9.0

Development

Successfully merging this pull request may close these issues.

Can't Load or Save Mixer Channels Setup on Mac

4 participants

@softins @emlynmac @hoffie @ann0see