Skip to content

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Mar 24, 2022

This is done to (hopefully) silence some Codacy errors

Short description of changes

Edit: I think Codacy is very picky on .md files - we should probably ignore warnings from it. However, it is still good to have a consistent style

CHANGELOG: Internal: Applied standard style to .md files

Context: Fixes an issue?
No.

Does this change need documentation? What needs to be documented and how?
No.

Status of this Pull Request
Ready for review. Probably also for merge

What is missing until this pull request can be merged?
Nothing.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see force-pushed the patch/beautifyMD branch 3 times, most recently from c07327c to 3925249 Compare March 24, 2022 22:21
This is done to have a consistent .md style
Copy link
Collaborator

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blimey...

@ann0see
Copy link
Member Author

ann0see commented Mar 27, 2022

Should be merged before #2553 is handled

Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yet another thing to check on PRs? :/

@ann0see ann0see merged commit 0bbd298 into jamulussoftware:master Mar 27, 2022
@ann0see ann0see deleted the patch/beautifyMD branch March 27, 2022 20:54
@ann0see
Copy link
Member Author

ann0see commented Mar 27, 2022

In theory yes. But I don’t think it is worth it

@pljones pljones added this to the Release 3.9.0 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants