Scripts: Apply shellcheck suggestions #2547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic used eval to dynamically create variables. This is hard to follow. Instead, explicitly name the relevant two variables. Also, introduce readable variable names. Related: jamulussoftware#2474
ann0see
reviewed
Mar 24, 2022
pljones
reviewed
Mar 24, 2022
ann0see
reviewed
Mar 24, 2022
Member
ann0see
left a comment
There was a problem hiding this comment.
I think the most important thing to check here is the mac_deploy.sh script. I'll check it on my VM and then approve.
ann0see
approved these changes
Mar 24, 2022
Member
ann0see
left a comment
There was a problem hiding this comment.
Tested on macOS and it works.
Some suggestions do not apply. For those, a comment is added to disable the check and explain why shellcheck cannot properly judge it. Related: jamulussoftware#2474
e1abe9e to
06bffcc
Compare
1 task
Member
pljones
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
This PR applies the suggestions by
shellcheckto all our.shscripts.Some suggestions do not apply. For those, a comment is added to disable the check and explain why shellcheck cannot properly judge it.
CHANGELOG: Internal: Made all shell scripts shellcheck-clean.
Context: Fixes an issue?
Related: #2474
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready for review.
What is missing until this pull request can be merged?
Final CI runs & reviews.
Checklist