Skip to content

Conversation

@pljones
Copy link
Collaborator

@pljones pljones commented Mar 22, 2022

Short description of changes
Stop the build if the audio SDK is missing

CHANGELOG: Stop the build if the audio SDK is missing

Context: Fixes an issue?
See #2525 (comment)

Does this change need documentation? What needs to be documented and how?
No.

Status of this Pull Request
Hopefully doesn't break the build when it should work. WFM...

What is missing until this pull request can be merged?
Could do with others testing the other configurations (I don't have 32bit Windows or build 32bit on 64bit).

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@hoffie hoffie added this to the Release 3.9.0 milestone Mar 23, 2022
@pljones pljones force-pushed the bugfix/fail-on-missing-build-artifacts branch from 2cd3e91 to 3cb05d7 Compare March 23, 2022 09:21
@pljones pljones requested review from a team and softins and removed request for a team March 23, 2022 16:56
Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but looks good to me.

@ann0see ann0see merged commit 429cedb into jamulussoftware:master Mar 23, 2022
@pljones pljones deleted the bugfix/fail-on-missing-build-artifacts branch March 23, 2022 20:01
@pljones pljones restored the bugfix/fail-on-missing-build-artifacts branch March 23, 2022 21:28
@pljones pljones deleted the bugfix/fail-on-missing-build-artifacts branch March 23, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants