Remove deploy_linux.sh since no longer in use #2512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deploy_linux.sh file has not been in use since we moved over to building binaries (.deb). Users who still depend on compiling from source can use git, the GitHub source code release or manually execute make dist on a git clone. Related to: jamulussoftware#2510 (comment)
4860b8b to
15c43f2
Compare
pljones
approved these changes
Mar 15, 2022
Collaborator
pljones
left a comment
There was a problem hiding this comment.
On the assumption this doesn't break the build....
hoffie
approved these changes
Mar 15, 2022
Member
Author
|
I doubt it changes anything. |
Member
Author
|
Merging. It’s just a code ql hiccup again. |
Member
Author
|
@pljones I shortened the changelog entry. Can you put this into the release changelog? |
Collaborator
|
I'll go with the even shorter version I used. The ChangeLog shouldn't provide directions to people on how to deal with the change. That should be provided in the current documentation. |
Member
Author
|
Then maybe at least add that we no longer use the script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
The deploy_linux.sh file has not been in use since we moved over to debian building. Users who still use the source can use git or manually execute make dist.
Context: Fixes an issue?
Related to: #2510 (comment)
Does this change need documentation? What needs to be documented and how?
CHANGELOG: Linux: Removed
linux/deploy_linux.shscript. Linux users should use the.debfiles download compile from git.Status of this Pull Request
Ready to be merged
What is missing until this pull request can be merged?
Review
Checklist