Autobuild: Combine and simplify Linux build scripts #2509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
ann0see
requested changes
Mar 14, 2022
Member
ann0see
left a comment
There was a problem hiding this comment.
Seems to be broken? Probably the deb fine didn’t get moved correctly.
3e7d094 to
d096475
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
d096475 to
1f0ae72
Compare
This comment was marked as outdated.
This comment was marked as outdated.
pljones
reviewed
Mar 14, 2022
ann0see
reviewed
Mar 14, 2022
Member
ann0see
left a comment
There was a problem hiding this comment.
This script looks quite good - in comparison what we need to do for other systems.
See my comment below.
Related: jamulussoftware#2503 - Move all autobuild/linux/* scripts to a single .github/autobuild/linux_deb.sh script which is called for the different stages (setup/build/get-artifacts). - Condense redundant parameter parsing into a single step - Create functions with proper names for larger steps - Inline Github artifact output definition as it's shorter that way - Make shellcheck-clean
1f0ae72 to
4f16ba5
Compare
ann0see
approved these changes
Mar 14, 2022
pljones
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all autobuild/linux/* scripts to a single .github/autobuild/linux_deb.sh script which is called for the different stages
(setup/build/get-artifacts).
Condense redundant parameter parsing into a single step
Create functions with proper names for larger steps
Inline Github artifact output definition as it's shorter that way
Make shellcheck-clean
Short description of changes
CHANGELOG: Autobuild: Refactored and simplified Linux build scripts.
(will be condensed...)
Context: Fixes an issue?
Related: #2503
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
Reviews.
Checklist