Skip to content

Conversation

@hoffie
Copy link
Member

@hoffie hoffie commented Mar 12, 2022

Short description of changes

This PR drops the install-qt.sh script and uses aqtinstall to install Qt similar to Windows, Mac and iOS builds.
There is no need to update the caching logic as it only works on the Qt installation path, which is unchanged.

CHANGELOG: Android: Migrated to aqtinstall for Qt installation.

Context: Fixes an issue?

Fixes #2434

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Ready.

What is missing until this pull request can be merged?

Ready.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want -- build is green and APK still works on my phone. APK size is unchanged.
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@hoffie hoffie added this to the Release 3.9.0 milestone Mar 12, 2022
@hoffie hoffie requested a review from ann0see March 12, 2022 23:47
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since you tested it and CI is green-ish (CodeQl still makes a mess).

@hoffie hoffie merged commit 6d03ea7 into jamulussoftware:master Mar 13, 2022
@hoffie hoffie deleted the android-use-aqt branch March 19, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: Use aqt to download Qt

3 participants