Do not show ASIO related warning message if using JACK #2494
Conversation
There was a problem hiding this comment.
Basically fd7bfe6 split out as separate commit.
That's matches the commit [edit]content[/edit] this PR contains. You might have meant another one?
Approving solely on the fact that the previous logic simply does not look correct for non-ASIO builds.
|
Yes. Basically it's has the same diff (I just copy and pasted it and didn't cherry-pick). Probably that means it's the same commit? |
No. I wanted to get the ( WITH_JACK ) into upstream. Just for my own clarification: |
Ok.
No, sorry for the confusion. I misread the commit IDs. They are not the same. The commit hash is determined by commit metadata (author, date, message, ...) and commit content (a tree object which describes the full content of the repo). |
|
Ok. Thanks! Basically it is a split out of #2168 |
Short description of changes
Basically fd7bfe6 split out as separate commit.
CHANGELOG: Windows: The JACK build now no longer gives an ASIO related warning message on an incompatible state
Context: Fixes an issue?
No.
Does this change need documentation? What needs to be documented and how?
No. Bug Fix
Status of this Pull Request
Not yet tested, just ported
What is missing until this pull request can be merged?
Testing and review.
Checklist