Automatically build IPA for iOS #2355

ann0see · 2022-02-07T16:09:17Z

Short description of changes
Automatically builds unsigned ipa files for iOS. This might enable quicker installing of the iOS version with a tool like Sideloadly: https://sideloadly.io

Context: Fixes an issue?
Related to #2105

Does this change need documentation? What needs to be documented and how?
Yes. But only if it is tested to work

Status of this Pull Request
Needs testing and a decision if we want to actually go this way (I think it's the only way to provide semi-official non-app-store builds)

What is missing until this pull request can be merged?
Review by @emlynmac and @softins

Checklist

I've verified that this Pull Request follows the general code principles
I tested my code and it does what I want
My code follows the style guide
I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
I've filled all the content above

emlynmac · 2022-02-07T16:15:05Z

autobuild/ios/artifacts/autobuild_ios_2_build.sh

+
+cd "${THIS_JAMULUS_PROJECT_PATH}"
+
+qmake -spec macx-xcode Jamulus.pro


I would have expected the spec to be the iOS build rather than the macx target here?

Yes. But that's what builds for iOS

so how does:

else:ios { QMAKE_INFO_PLIST = ios/Info.plist QT += macextras OBJECTIVE_SOURCES += ios/ios_app_delegate.mm HEADERS += ios/ios_app_delegate.h HEADERS += ios/sound.h OBJECTIVE_SOURCES += ios/sound.mm QMAKE_TARGET_BUNDLE_PREFIX = io.jamulus QMAKE_APPLICATION_BUNDLE_NAME. = $$TARGET LIBS += -framework AVFoundation \ -framework AudioToolbox }

play into the build?

Probably it generates the .xcodeproject for iOS

Since the build includes the iOS version of Qt, probably qmake knows it is building for iOS. Certainly the log shows a line for building ios/sound.mm

ann0see · 2022-02-07T16:16:15Z

BTW: https://dantheman827.github.io/ios-app-signer/ seems to be maintained (?) while the other app I mentioned doesn't. There's spam

emlynmac · 2022-02-07T16:16:55Z

Once we have this building, I can add some of the signing to the GitHub repo in the same way as for the Mac app.

ann0see · 2022-02-07T16:18:58Z

Yes, maybe we can generate IPA files then.

.github/workflows/autobuild.yml

ann0see · 2022-02-07T16:32:06Z

autobuild/ios/artifacts/autobuild_ios_3_copy_files.sh

@@ -0,0 +1,48 @@
+#!/bin/sh -e


This is mostly copied from macOS.

ann0see · 2022-02-07T16:40:30Z

Once we have this building, I can add some of the signing to the GitHub repo in the same way as for the Mac app.

This would probably allow us to generate IPA files? Probably users would still need to sign them themselves. Releasing on TestFlight seems to work as https://www.uketok.com/about.php did that.

ann0see · 2022-02-07T16:55:13Z

Other build assets can be found here: https://github.com/jamulussoftware/jamulus/actions/runs/1807584540

emlynmac · 2022-02-07T16:57:28Z

Once we have this building, I can add some of the signing to the GitHub repo in the same way as for the Mac app.

This would probably allow us to generate IPA files? Probably users would still need to sign them themselves. Releasing on TestFlight seems to work as https://www.uketok.com/about.php did that.

Yes, I'd set it up to build and push to TestFlight. Then we can have an open beta available.

ann0see · 2022-02-07T21:28:38Z

After trying multiple times, it seems as if using the produced file needs Xcode to be installed. That's exactly what I wanted to avoid. Probably with signing we can produce fake-signed IPA files which could then be installed via some external app.

ann0see · 2022-02-07T21:36:00Z

Wait a moment. I think I got it to work! Let's wait and see what the CI produces.

ann0see · 2022-02-07T22:34:16Z

Just installed the unsigned IPA via Sideloadly on my phone and it worked! I'd see this PR as ready for review. If we merge it, it should be squash-merged

ann0see · 2022-02-20T09:50:08Z

Can be reviewed further and merged soon

ann0see · 2022-02-21T21:32:17Z

autobuild/ios/artifacts/autobuild_ios_1_prepare.sh

+echo "Install dependencies..."
+python3 -m pip install "aqtinstall==${AQTINSTALL_VERSION}"
+python3 -m aqt install-qt --outputdir "${QT_DIR}" mac ios ${QT_VER}
+


I think this needs caching.

softins

I'll review more later when I get time. Would like to try it on my iPad.

.github/workflows/autobuild.yml

ann0see · 2022-02-25T21:40:47Z

Should be squash merged.

ann0see · 2022-03-04T20:15:51Z

@softins @hoffie I think this is ready to merge.

softins

Well the actual changes look sensible. And now I have managed to get sideloadly onto my Mac and use it to load the ipa onto my iPad. It seems to run ok, and I have listened to a couple of sessions, so happy to approve.

hoffie

Build logic looks fine, but I don't know anything about iOS app packaging.

ann0see · 2022-03-09T21:53:20Z

CHANGELOG: Feature: Provide unsigned iOS builds for easy install on iOS devices. Please note that you will need to sign the app yourself (usually done via a computer). The app will only run for 7 days before you need to resign it.

emlynmac reviewed Feb 7, 2022

View reviewed changes

softins reviewed Feb 7, 2022

View reviewed changes

.github/workflows/autobuild.yml Outdated Show resolved Hide resolved

ann0see force-pushed the autobuild/iOSBuild branch 2 times, most recently from 6d2770e to 411f857 Compare February 7, 2022 16:29

ann0see commented Feb 7, 2022

View reviewed changes

autobuild/ios/artifacts/autobuild_ios_3_copy_files.sh

@@ -0,0 +1,48 @@

#!/bin/sh -e

Copy link

Member Author

ann0see Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly copied from macOS.

ann0see changed the title ~~Automatically build archive for iOS~~ Automatically build IPA for iOS Feb 7, 2022

ann0see marked this pull request as ready for review February 7, 2022 22:35

hoffie added this to the Release 3.9.0 milestone Feb 7, 2022

ann0see force-pushed the autobuild/iOSBuild branch 2 times, most recently from d7d6608 to 4ee4dda Compare February 8, 2022 12:46

ann0see mentioned this pull request Feb 8, 2022

Add iOS ipa installation guide jamulussoftware/jamuluswebsite#701

Merged

2 tasks

ann0see requested review from hoffie and softins February 20, 2022 18:47

ann0see commented Feb 21, 2022

View reviewed changes

softins reviewed Feb 21, 2022

View reviewed changes

.github/workflows/autobuild.yml Outdated Show resolved Hide resolved

ann0see requested a review from softins February 25, 2022 21:40

Automatically build IPA for iOS

8794711

ann0see force-pushed the autobuild/iOSBuild branch from bf04779 to 8794711 Compare March 2, 2022 21:23

softins approved these changes Mar 4, 2022

View reviewed changes

hoffie approved these changes Mar 4, 2022

View reviewed changes

ann0see merged commit 72fe918 into jamulussoftware:master Mar 4, 2022

ann0see deleted the autobuild/iOSBuild branch March 4, 2022 23:02

ann0see mentioned this pull request Mar 4, 2022

Add caching for iOS build #2462

Open


		cd "${THIS_JAMULUS_PROJECT_PATH}"

		qmake -spec macx-xcode Jamulus.pro

Automatically build IPA for iOS #2355

Automatically build IPA for iOS #2355

Uh oh!

Conversation

ann0see commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

emlynmac Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

ann0see Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

emlynmac Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

ann0see Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

softins Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

ann0see commented Feb 7, 2022

Uh oh!

emlynmac commented Feb 7, 2022

Uh oh!

ann0see commented Feb 7, 2022

Uh oh!

Uh oh!

ann0see Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

ann0see commented Feb 7, 2022

Uh oh!

ann0see commented Feb 7, 2022

Uh oh!

emlynmac commented Feb 7, 2022

Uh oh!

ann0see commented Feb 7, 2022

Uh oh!

ann0see commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ann0see commented Feb 7, 2022

Uh oh!

ann0see commented Feb 20, 2022

Uh oh!

ann0see Feb 21, 2022

Choose a reason for hiding this comment

Uh oh!

softins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ann0see commented Feb 25, 2022

Uh oh!

ann0see commented Mar 4, 2022

Uh oh!

softins left a comment

Choose a reason for hiding this comment

Uh oh!

hoffie left a comment

Choose a reason for hiding this comment

Uh oh!

ann0see commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ann0see commented Feb 7, 2022 •

edited

Loading

ann0see commented Feb 7, 2022 •

edited

Loading

ann0see commented Mar 9, 2022 •

edited

Loading