-
Notifications
You must be signed in to change notification settings - Fork 238
Use dch instead of hack to generate changelog #2138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Firstly, thank you @npostavs for addressing the build warnings about the
|
|
After further experimentation, this is the current state of my It uses It exports |
Ah, I missed that.
I went with this option.
Added to the PR. |
|
@npostavs what is the Next action on this? Review, testing? |
|
Yeah, I believe the code is ready, and I have addressed all of @softin's concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the one change required. Everything else looks ok, and I have successfully built a deb.
ba21110 to
b743299
Compare
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor thought. It’s still not optimal, but probably better then now.
softins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you also test if the automated change log detection for GH releases still works? Seems ok, but better test it.
Urgh. Didn't read... Should be ok...
|
|
||
| my $logversion = ""; | ||
| my $entry; | ||
| while (my $line = <$fh>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should stop looping through the file if we already found the correct version ($logversion changed to the next version). Then we could also check if a version wasn't found as soon as we reached the EOF and output some error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@npostavs could you please insert a break statement to stop looping through unneeded lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yep, done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
|
||
| my $logversion = ""; | ||
| my $entry; | ||
| while (my $line = <$fh>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@npostavs could you please insert a break statement to stop looping through unneeded lines?
Also exit early once we're done processing the version relevant lines.
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Short description of changes
Use dch to generate Debian changelog instead of handrolled shell calls
Context: Fixes an issue?
This is an alternate version of #1767
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Working implementation, a sample output is changelog.dch.log. (updated with Nov 29th changes)
What is missing until this pull request can be merged?
Possibly the "initial release" line needs to be removed somehow.Checklist