Mac build: Pin dmgbuild to 1.4.2 as 1.5.0 is broken #1796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Heh, the upstream maintainer was really quick... 1.5.1 was released with a fix. I'm still wondering whether we should do the pinning for two reasons:
Therefore, I'm keeping the PR open for now. |
Member
Author
... and @softins noticed that the new version is also broken (dmgbuild/dmgbuild#41). I'd suggest merging this PR for now. |
softins
approved these changes
May 31, 2021
pljones
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
dmgbuildin the Mac build process. Version 1.5.0 was released some hours ago and it breaks our build process as seen here:https://github.com/hoffie/jamulus/runs/2709826916?check_suite_focus=true#step:6:1329 (that branch is a copy of
master)This PR pins the version to the version we've been using previously.
Unless
dmgbuildis updated again on PyPI, this PR will have to be merged for the final Jamulus release as autobuild will fail otherwise. At the same time, it should be save to merge because it restores the state to what was used for rc2.I have raised an upstream issue as well: dmgbuild/dmgbuild#40