Generate .qm files during build #1303
Conversation
This removes .qm files from git, adds them to .gitignore and changes Jamulus.pro to generate the files dynamically during build in a way which hopefully even works on ancient Qt versions. This makes use of custom compiler support in qmake which seems to be available (at least) as of Qt 5.5. https://doc.qt.io/archives/qt-5.5/qmake-advanced-usage.html#adding-compilers Fixes jamulussoftware#1111
|
Windows fails. Probably you'd need to use another path and can't just run lrelease same for android. |
softins
left a comment
There was a problem hiding this comment.
This needs a bit more investigation before being included. I went round the same loop a month or so ago, without success. The build gave warnings that the .qm resources could not be found, as they were mentioned in the resource file. And if I built anyway, I think the executable did not include the other languages.
Currently, building from source does not have lrelease as a dependency, and with this approach it will do. That’s ok, but a change in requirements.
Like I said last time, I think most Qt developers -- and that should be anyone building from source -- would have |
|
I'm closing this for now as I'm not sure whether it's the right approach to tackle this anymore. |
This removes .qm files from git, adds them to .gitignore and changes Jamulus.pro to generate the files dynamically during build in a way which hopefully even works on ancient Qt versions.
This makes use of custom compiler support in qmake which seems to be
available (at least) as of Qt 5.5.
https://doc.qt.io/archives/qt-5.5/qmake-advanced-usage.html#adding-compilers
Tested on Linux, needs validation on Mac/Windows.
Fixes #1111