Skip to content

Ability to delete Server and Directory from a list should be the same #3233

@pljones

Description

@pljones

What is the current behaviour and why should it be changed?

In the Client:

  • In the Settings Dialog, Advanced tab, the Custom Directories list allows adding and removing of Directories. To remove a Directory from the list, the edit box must be cleared and enter pressed or focus moved to another field with the box empty.
  • In the Connect Dialog, the Server list (near the "Connect" button) allows adding and, recently, removing of Servers. To remove a Server, from the list, the <[X] button is pressed.

In the Server, on the Options tab:

  • The recording directory can be set or cleared.
  • The server list filename (when running as a Directory) can be set or cleared.

In both cases, to clear the value, the <[X] button is pressed.

The Settings Dialog, Advanced tab, Custom Directories list isn't as easy to use or obvious in how to remove an entry as the others.

Describe possible approaches

The fields in the Server are read-only, with a dialog to select a new value for the field. The dialog itself cannot be used to clear the value. So having the extra "clear" button is necessary.

The Client Connect dialog has used the same approach for the Server list.

The options are:

  • Add a <[X] button to the Advanced, Custom Directories list to allow deleting the selected value the same was as the Connect dialog and remove the existing method.
  • Add a <[X] button to the Advanced, Custom Directories list to allow deleting the selected value the same was as the Connect dialog, whilst retaining the existing method.
  • Add the same "clear the field and move focus" method to the Connect dialog (hitting enter won't work here as it would attempt to connect, thus connecting to the current Genre Directory as no server was selected)

I don't think the Server buttons should be changed.

I think the best method is to switch the Advanced, Custom Directories list to use the <[X] button.

Has this feature been discussed and generally agreed?

See #3159 (comment) for earlier discussion.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions