Windows Build: Fail workflow early on errors #2276
Description
Describe the bug
The Windows Build process should be checked and improved regarding error handling. For example, if a step in the workflow such as "Prepare for Windows JACK (artifact)" has problems, this is not detected in the workflow.
Instead, the workflow continues, runs the build, exits successfully with cryptic error messages ("Qt license check failed"). This wastes computing ressources and developer time.
To Reproduce
The most common cause are sporadic failures such as Qt download errors.
Expected behavior
Errors should lead to workflow failure immediately.
Screenshots
From https://github.com/jamulussoftware/jamulus/runs/4936344409?check_suite_focus=true
Prepare for Windows JACK (artifact)
Finished installation of opengl32sw-64-mesa_12_0_rc2.7z in 2.05521980
Finished installation of qtconnectivity-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86_64.7z in 6.87078230
Finished installation of qt3d-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86_64.7z in 13.36649460
Caught ArchiveConnectionError, terminating installer workers
Failure to connect to https://download.qt.io/online/qtsdkrepository/windows_x86/desktop/qt5_5152/qt.qt5.5152.win64_msvc2019_64/5.15.2-0-202011130602qtremoteobjects-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86_64.7z.sha1: ReadTimeout
Build for Windows JACK (artifact)
[vcvarsall.bat] Environment initialized for: 'x64'
Error: Qt license file was not found!
Project ERROR: License check failed! Giving up ...
Native command C:\Qt\5.15.2\msvc2019_64\bin\qmake.exe returned with exit code 3
At D:\a\jamulus\jamulus\windows\deploy_windows.ps1:38 char:9
+ Throw "Native command $Command returned with exit code $LastE ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : OperationStopped: (Native command ...ith exit code 3:String) [], RuntimeException
+ FullyQualifiedErrorId : Native command C:\Qt\5.15.2\msvc2019_64\bin\qmake.exe returned with exit code 3
Upload Artifact 1 to Job
Error: No files were found with the provided path: deploy/jamulus_3.8.1dev-2b3f1d4_win_jack.exe. No artifacts will be uploaded.
Operating system
CI/Windows
Version of Jamulus
master
Additional context
- Check Prepare step
- Check Build step
- Check Post-Build step