Check if get_parent_post exists as it may throw a fatal error on WP 5.7#48
Closed
audrasjb wants to merge 1 commit intojamiechong:masterfrom
Closed
Check if get_parent_post exists as it may throw a fatal error on WP 5.7#48audrasjb wants to merge 1 commit intojamiechong:masterfrom
audrasjb wants to merge 1 commit intojamiechong:masterfrom
Conversation
Contributor
|
@audrasjb I'm not the developer, but that function in the plugin is namespaced, so it shouldn't throw a "fatal". I am going to keep an eye on this as I was looking to see why there are 404 errors to their "pro" site which seems to be no longer accessible. |
Owner
|
@audrasjb Indeed @thefrosty is correct in that the @thefrosty the 404 errors should hopefully be resolved now. |
Author
|
Indeed, that was a false positive in our search results 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
WordPress 5.7 will introduce a
get_parent_post()function in WP Core.It appears that this plugin is the only one in the WordPress plugin repository to use in.
This pull request adds a
function_existscheck to avoid fatal errors.For reference, see https://core.trac.wordpress.org/ticket/33045#comment:42
Thank you,
Jb