Fix issue when collecting launchd data#62
Merged
c7bercat merged 3 commits intojamf:task/pr-62from Nov 22, 2024
Merged
Conversation
… path that no longer exists. this would previously cause an abort for trying to unwrap an optional 2.2.1 output ``` Could not cast value of type '__NSArrayM' (0x1f3f28d00) to 'NSString' (0x1f3f24ff0). zsh: abort sudo /usr/local/bin/aftermath ```
…tionary output (although this does put escape characters in paths, which are still valid, jsut not strictly representing the actual dict value)
c7bercat
approved these changes
Nov 22, 2024
golbiga
approved these changes
Nov 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue when collecting launchd data if a launchd item references a path that no longer exists.
this would previously cause an abort for trying to unwrap an optional
2.2.1 output
For example, a launchd item is created but the bundle/path it refers to is deleted then attempting to generate a sha for the path will fail. This PR updates the string variables so they aren't optionals and protects the attempt to generate a sha behind an
if letwith an appropriate log if the attempt fails.