Skip to content

Specify output filename#44

Merged
mattbenyo merged 3 commits intomainfrom
specify-output-filename
Dec 8, 2022
Merged

Specify output filename#44
mattbenyo merged 3 commits intomainfrom
specify-output-filename

Conversation

@c7bercat
Copy link
Copy Markdown
Collaborator

@c7bercat c7bercat commented Dec 6, 2022 •
edited
Loading

  • Moved isDirectoryThatExists() and isFileThatExists() to the FileManager extension class
  • Created deletingPathExtension() also in the FileManager extension class
  • Updated MoveTemporaryCaseDir() to
    • Check for existence of output location
    • Accept either a dir or a file

Addresses #35

@mattbenyo mattbenyo merged commit 067a182 into main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbradley89 jbradley89 jbradley89 approved these changes

@saljooki saljooki Awaiting requested review from saljooki saljooki is a code owner

+1 more reviewer

@mattbenyo mattbenyo mattbenyo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c7bercat @jbradley89 @mattbenyo