Skip to content

Edge and CSV parser#42

Merged
jbradley89 merged 11 commits intojamf:mainfrom
stuartjash:stuartjash_edge
Dec 2, 2022
Merged

Edge and CSV parser#42
jbradley89 merged 11 commits intojamf:mainfrom
stuartjash:stuartjash_edge

Conversation

@stuartjash
Copy link
Copy Markdown
Contributor

@stuartjash stuartjash commented Nov 15, 2022 •
edited
Loading

  • added support for Edge browser (pretty much identical to Chrome)
  • fixed typo in browsers.txt file
  • instead of using computer name for aftermath directory name, using serial number instead. This is much more consistent. if serial number comes back as null, use the device name
  • removed timestamp from file name to remove clutter and added a 'started collection' log line in the aftermath.log
  • Wrote our own csv parser as the SwiftCSV package was throwing errors and they were unable to be handled gracefully. This change required rewrites to much of the analysis section. This should address Issue quotation(message: "Can\'t have non-quote here: F") #38
  • added macOS 11 compatibility for collection only. Analysis still requires macOS 12 or greater. Per issue Does not run on macOS 11 #41
  • updated program entry to exit if not root
  • added shields to readme for readability

@stuartjash stuartjash changed the title Edge and minor updates Edge and CSV parser Nov 15, 2022
@jbradley89 jbradley89 merged commit 623aa77 into jamf:main Dec 2, 2022
@stuartjash stuartjash deleted the stuartjash_edge branch June 2, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbradley89 jbradley89 jbradley89 approved these changes

@c7bercat c7bercat Awaiting requested review from c7bercat c7bercat is a code owner

+1 more reviewer

@mattbenyo mattbenyo mattbenyo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuartjash @jbradley89 @mattbenyo