Merged
Conversation
ball42
reviewed
Oct 12, 2023
ball42
reviewed
Oct 12, 2023
ball42
approved these changes
Oct 12, 2023
Collaborator
ball42
left a comment
There was a problem hiding this comment.
New requirements.txt tested OK in v3.0.3 and the version of v3.1.0 available in the develop branch.
Collaborator
There was a problem hiding this comment.
Thanks for going ahead and fixing this! The new requirements.txt file worked for installing stable dependencies within a JAWA venv in testing. The code has been adjusted in the upcoming release v3.1.0 to avoid this error and also provide compatibility with Flask 3.0.0. However, it's still very wise to include the tested versions for packages/libraries within the requirements.txt, so this convention will be adopted moving forward and will include the other listed items in requirements.txt.
This was referenced Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed to this file with versions that will solve #42 and #43