Merged
Conversation
… logger function so we aren't re-initializing the logger everytime we write to the log.
# Conflicts: # app.py
…dded parameters to setup_child_logger()
ball42
approved these changes
May 19, 2022
Collaborator
ball42
left a comment
There was a problem hiding this comment.
New logging methods are working as expected 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lock in logging changes. Logger init function and child spawner are now in bin/logger.py
Adding a child logger to nay py file in the project requires 3 lines of code:
Then logging statements are the same syntax everywhere:
logthis.info("Message to be logged.")The app.py 'main' logger is defined with hard coded name of
'app'because(__name__)produced unwanted results.child log statements reflect the hierarchy and filename they came from, so troubleshooting and is simplified.
example log entries: