4.4.0 rc3 bug fix#3
Closed
jamesmisson wants to merge 2 commits into
Closed
Conversation
demiankatz
suggested changes
May 27, 2026
demiankatz
left a comment
There was a problem hiding this comment.
This looks reasonable to me, @jamesmisson (though I confess I only took a quick look). I'd suggest closing this PR and opening a fresh one against the upstream repository's release-4.4.0 branch, however -- then after that is merged you can create the RC3 PR against it from here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-4.4.0-rc2 had a bug where the rendering of the choice button was out of sync with the loading of the manifest. In certain conditions, the manifest hadn't loaded before the UI was created, so it wasn't aware of the choice.
This cleans up some of the redundant condition checks that were causing this - one on the extension, and the other in
createChoiceSwitchin the OpenseaDragonCenterPanel. Now, the only time that the presence of choice is checked, is inopenPagesHandler, after the page has loaded, which makes the button visible or invisible. This is more in line with how other UI elements are rendered anyway.