Skip to content

fix: parse check flags after positional paths#49

Merged
jakekaplan merged 3 commits intomainfrom
fix/check-flags-after-path
Feb 15, 2026
Merged

fix: parse check flags after positional paths#49
jakekaplan merged 3 commits intomainfrom
fix/check-flags-after-path

Conversation

@jakekaplan
Copy link
Copy Markdown
Owner

@jakekaplan jakekaplan commented Feb 15, 2026

loq check . --output-format json was being interpreted as a path list because PATH accepted hyphen-prefixed values. That made trailing flags like --output-format and --no-cache silently stop working.

This change keeps loq check - support by normalizing - to an internal --stdin flag before clap parsing, and removes broad hyphen-value parsing from PATH. Trailing flags now parse correctly while stdin behavior stays intact.

Example: loq check a.txt --output-format json now returns JSON output instead of text.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 772256a Previous: b97a7fa Ratio
cpython 0.0009402560200000001 seconds (± 0) 0.05583968895999999 seconds (± 0.0008) 0.016838489567403213
airflow 0.0009572294200000003 seconds (± 0) 0.15678493406 seconds (± 0.0009) 0.006105366091066367
prefect 0.0009368286200000001 seconds (± 0) 0.06596280506 seconds (± 0.0007) 0.014202376917534927
ruff 0.00098601592 seconds (± 0.0001) 0.13796103466000004 seconds (± 0.0027) 0.007147060925064824

This comment was automatically generated by workflow using github-action-benchmark.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.66%. Comparing base (3065f71) to head (772256a).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   98.63%   98.66%   +0.03%     
==========================================
  Files          21       21              
  Lines        3225     3305      +80     
==========================================
+ Hits         3181     3261      +80     
  Misses         44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakekaplan jakekaplan merged commit 96c507a into main Feb 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant