Skip to content

Add "version: PATH" to pull pyright from $PATH#107

Merged
jakebailey merged 7 commits into
mainfrom
version-path
Apr 11, 2024
Merged

Add "version: PATH" to pull pyright from $PATH#107
jakebailey merged 7 commits into
mainfrom
version-path

Conversation

@jakebailey

@jakebailey jakebailey commented Apr 10, 2024

Copy link
Copy Markdown
Owner

version: PATH instructs the action to instead look on $PATH for pyright. This is useful in situations where dev dependencies already install pyright, e.g. via PyPI.

- run: |
    python -m venv .venv
    source .venv/bin/activate
    pip install -r dev-requirements.txt # includes pyright
- run: echo "$PWD/.venv/bin" >> $GITHUB_PATH

- uses: jakebailey/pyright-action@v2
  with:
    version: PATH

@codecov

codecov Bot commented Apr 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a9434fd) to head (6661384).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #107   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          590       633   +43     
  Branches       118       127    +9     
=========================================
+ Hits           590       633   +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakebailey jakebailey changed the title Add "version: path" to pull pyright from $PATH Add "version: PATH" to pull pyright from $PATH Apr 10, 2024
@jakebailey jakebailey marked this pull request as ready for review April 10, 2024 17:40
Comment thread .github/workflows/ci.yml Outdated
@jakebailey jakebailey merged commit 32e0647 into main Apr 11, 2024
@jakebailey jakebailey deleted the version-path branch April 11, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant