Skip to content

[#240] fixes parseBoolean according spec#279

Merged
lukasj merged 1 commit intojakartaee:masterfrom
laurentschoelens:gh-240
Sep 13, 2023
Merged

[#240] fixes parseBoolean according spec#279
lukasj merged 1 commit intojakartaee:masterfrom
laurentschoelens:gh-240

Conversation

@laurentschoelens
Copy link
Copy Markdown
Contributor

Fixes #240 : parseBoolean function could return true or false value when, according to spec, it should not accept the string literal as valid boolean expression

Adding UT to validate behaviour

Copy link
Copy Markdown
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit b023399 into jakartaee:master Sep 13, 2023
@laurentschoelens laurentschoelens deleted the gh-240 branch September 13, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

javax.xml.bind.DatatypeConverter.parseBoolean("10") returns true instead of false or an Exception

2 participants