Issue 124 add java nio path support#126
Conversation
Changed the internal implementation to use Path instead of File.
|
I see the builds are failing due to Javadoc. I will correct this. Also, it seems like the eca issue is related to the multiple email addresses I have on my GitHub account. I have accepted the ECA but the automated test seems to be confused. I will see what can be done. |
lukasj
left a comment
There was a problem hiding this comment.
in general, looks good, yet some fine-tunning is needed:
- avoid using tabs and stick with current formatting
- reformatting comments as part of the change does not make reviewer's life easier
- copyright year should be updated
- change should be noted in the spec document, at least in the changelog
should marking File variants as deprecated be considered or do you propose to just keep them as they are for now?
- Also updated to latest maven javadoc plugin.
Should I go back and change it back to what it was. Sorry, the formatting style seemed very old-school to me, so I thought I was making things better but I understand the value of consistency. I am happy to change it back.
Understood.
Will do.
Will do.
This is a tough call. Personally, I would deprecate them however the JDK maintainers have seen fit not to deprecate File even though it has been superseded. I decided to follow the JDK lead and since it is not deprecated in the JDK, to leave it undeprecated in this API. As a compromise, I put a note in the Javadoc indicating that the Path version should be preferred. |
yes, please - avoid tabs for new stuff. The codebase should be updated in one go followed by the inclusion of the change in wrt deprecation - OK, let's keep it as it is and do nothing in that area for now wrt failing ECA check - last two commits were probably done through different username (...www...) which has not signed the ECA; the first one seems to be fine (probably)... can you try to amend them? |
PR supporting Issue #124