[StepSecurity] Apply security best practices#678
Merged
starksm64 merged 2 commits intojakartaee:mainfrom Nov 30, 2023
Merged
Conversation
resolve: jakartaee#677 Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
Ladicek
approved these changes
Jun 7, 2023
Member
Ladicek
left a comment
There was a problem hiding this comment.
LGTM, though I'm not exactly a fan of pinning actions that come directly from GitHub. The security risk there seems fairly minimal to me. On the other hand, there's a comment with the specific version number, and apparently Dependabot will bump those actions automatically, so it seems fine. Will see if Dependabot will also automatically bump those comments...
Member
|
LGTM, but a 2nd review would be nice. |
manovotn
approved these changes
Jun 7, 2023
Contributor
manovotn
left a comment
There was a problem hiding this comment.
LGTM but as same my other review (jakartaee/cdi-tck#473 (review)), the daily interval might prove irritating
Emily-Jiang
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is created by Secure Repo at the request of @fperezel. Please merge the Pull Request to incorporate the requested changes. Please tag @fperezel on your message if you have any questions related to the PR. You can also engage with the StepSecurity team by tagging @step-security-bot.
Security Fixes
resolve: #677
Least Privileged GitHub Actions Token Permissions
The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN.
Pinned Dependencies
GitHub Action tags and Docker tags are mutatble. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.
Keeping your actions up to date with Dependabot
With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).
Feedback
For bug reports, feature requests, and general feedback; please create an issue in step-security/secure-repo. To create such PRs, please visit https://app.stepsecurity.io/securerepo.
Signed-off-by: StepSecurity Bot bot@stepsecurity.io