Skip to content

Invalid parameter combinations in @Enhancement and @Registration meth…#581

Merged
manovotn merged 1 commit intojakartaee:masterfrom
manovotn:changeInvalidBceTreatment
Dec 8, 2021
Merged

Invalid parameter combinations in @Enhancement and @Registration meth…#581
manovotn merged 1 commit intojakartaee:masterfrom
manovotn:changeInvalidBceTreatment

Conversation

@manovotn
Copy link
Copy Markdown
Contributor

@manovotn manovotn commented Dec 8, 2021

…ods should be treated as definition errors.

As I pointed out in jakartaee/cdi-tck#329, I think we should handle these cases as definition errors.

…ods should be treated as definition errors.
@manovotn manovotn requested a review from Ladicek December 8, 2021 14:28
Copy link
Copy Markdown
Member

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine with me, though the difference between definition errors and deployment problems is kinda blurry in case of extensions (and especially Build Compatible Extensions, where there's no way for the extension to produce a definition error, unlike Portable Extensions).

@manovotn
Copy link
Copy Markdown
Contributor Author

manovotn commented Dec 8, 2021

DefinitionException (thrown in case of definition error) indicated that it's developer's error which is IMO the case here.
See https://github.com/eclipse-ee4j/cdi/blob/master/api/src/main/java/jakarta/enterprise/inject/spi/DefinitionException.java#L25-L29

(and especially Build Compatible Extensions, where there's no way for the extension to produce a definition error ....

Not sure I follow, there is little difference in producing definition versus deployment error for Build Compatible Extensions. Or am I missing something?

@Ladicek
Copy link
Copy Markdown
Member

Ladicek commented Dec 8, 2021

No, you're not. Sorry for confusion, the remark was only tangentially related.

@manovotn manovotn merged commit 95a3838 into jakartaee:master Dec 8, 2021
@manovotn manovotn deleted the changeInvalidBceTreatment branch December 8, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants