Skip to content

Move the session scope to CDI Full#577

Merged
manovotn merged 1 commit intojakartaee:masterfrom
Ladicek:move-session-scope-to-full
Dec 8, 2021
Merged

Move the session scope to CDI Full#577
manovotn merged 1 commit intojakartaee:masterfrom
Ladicek:move-session-scope-to-full

Conversation

@Ladicek
Copy link
Copy Markdown
Member

@Ladicek Ladicek commented Dec 7, 2021

When I was reviewing the remaining CDI 4.0 work, I realized we kept the session scope in CDI Lite. I believe it should be moved to CDI Full, because:

Hence, I'm proposing this PR to remove the session scope from Lite. It stays in Full.

Copy link
Copy Markdown
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@manovotn
Copy link
Copy Markdown
Contributor

manovotn commented Dec 8, 2021

Going to merge this, if @graemerocher has any comments/remarks, feel free to leave them here and we can reopen the discussion.

@manovotn manovotn merged commit 12047ee into jakartaee:master Dec 8, 2021
@Ladicek Ladicek deleted the move-session-scope-to-full branch December 8, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants