Remove Enhancement.BeanDefiningAnnotations#569
Merged
Ladicek merged 1 commit intojakartaee:masterfrom Dec 2, 2021
Merged
Conversation
The marker annotation `@Enhancement.BeanDefiningAnnotations` used to represent all bean defining annotations for the purpose of restricting the set of types on which `@Enhancement` should be performed. That, however, is pretty useless: `@Enhancement` is only performed on types that were discovered during type discovery, and all such types have a bean defining annotation. (Either they have it directly, or `@Dependent` is implied in case of classes added through `@Discovery` that don't have a bean defining annotation.)
manovotn
approved these changes
Dec 1, 2021
graemerocher
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The marker annotation
@Enhancement.BeanDefiningAnnotationsused to represent all bean defining annotations for the purpose
of restricting the set of types on which
@Enhancementshouldbe performed. That, however, is pretty useless:
@Enhancementis only performed on types that were discovered during type
discovery, and all such types have a bean defining annotation.
(Either they have it directly, or
@Dependentis impliedin case of classes added through
@Discoverythat don't havea bean defining annotation.)